From ceea064eeb8715340fe8f7d1f91c35231bb9ec16 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Ma=C5=9Blanka?= <michal@redpanda.com>
Date: Fri, 18 Oct 2024 12:10:02 +0200
Subject: [PATCH] r/tests: added test validating state after recovering from
 snapshot
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Michał Maślanka <michal@redpanda.com>
---
 src/v/raft/tests/BUILD                     | 25 +++++++++-
 src/v/raft/tests/CMakeLists.txt            |  1 +
 src/v/raft/tests/snapshot_recovery_test.cc | 55 ++++++++++++++++++++++
 3 files changed, 80 insertions(+), 1 deletion(-)
 create mode 100644 src/v/raft/tests/snapshot_recovery_test.cc

diff --git a/src/v/raft/tests/BUILD b/src/v/raft/tests/BUILD
index af1d7a60d24ae..35661bb6cacd0 100644
--- a/src/v/raft/tests/BUILD
+++ b/src/v/raft/tests/BUILD
@@ -1,4 +1,4 @@
-load("//bazel:test.bzl", "redpanda_cc_btest", "redpanda_test_cc_library")
+load("//bazel:test.bzl", "redpanda_cc_btest", "redpanda_cc_gtest", "redpanda_test_cc_library")
 
 redpanda_test_cc_library(
     name = "simple_raft_fixture",
@@ -181,3 +181,26 @@ redpanda_cc_btest(
         "@seastar//:testing",
     ],
 )
+
+redpanda_cc_gtest(
+    name = "snapshot_recovery_test",
+    timeout = "short",
+    srcs = [
+        "snapshot_recovery_test.cc",
+    ],
+    cpu = 1,
+    deps = [
+        ":raft_fixiture_retry_policy",
+        ":raft_fixture",
+        "//src/v/config",
+        "//src/v/model",
+        "//src/v/raft",
+        "//src/v/resource_mgmt:io_priority",
+        "//src/v/storage",
+        "//src/v/test_utils:gtest",
+        "//src/v/utils:unresolved_address",
+        "@fmt",
+        "@seastar",
+        "@seastar//:testing",
+    ],
+)
diff --git a/src/v/raft/tests/CMakeLists.txt b/src/v/raft/tests/CMakeLists.txt
index a0eb5e6e1798a..75f3e84f51008 100644
--- a/src/v/raft/tests/CMakeLists.txt
+++ b/src/v/raft/tests/CMakeLists.txt
@@ -54,6 +54,7 @@ set(gsrcs
     persisted_stm_test.cc
     replication_monitor_tests.cc
     mux_state_machine_test.cc
+    snapshot_recovery_test.cc
 )
 
 rp_test(
diff --git a/src/v/raft/tests/snapshot_recovery_test.cc b/src/v/raft/tests/snapshot_recovery_test.cc
new file mode 100644
index 0000000000000..a81efe4ff27f4
--- /dev/null
+++ b/src/v/raft/tests/snapshot_recovery_test.cc
@@ -0,0 +1,55 @@
+// Copyright 2023 Redpanda Data, Inc.
+//
+// Use of this software is governed by the Business Source License
+// included in the file licenses/BSL.md
+//
+// As of the Change Date specified in that file, in accordance with
+// the Business Source License, use of this software will be governed
+// by the Apache License, Version 2.0
+
+#include "model/fundamental.h"
+#include "model/metadata.h"
+#include "model/record.h"
+#include "model/record_batch_reader.h"
+#include "raft/tests/raft_fixture.h"
+#include "raft/tests/raft_fixture_retry_policy.h"
+#include "test_utils/test.h"
+
+using namespace raft;
+
+TEST_F_CORO(raft_fixture, test_snapshot_recovery) {
+    auto& n0 = add_node(model::node_id(0), model::revision_id(0));
+    auto& n1 = add_node(model::node_id(2), model::revision_id(0));
+    auto& n2 = add_node(model::node_id(3), model::revision_id(0));
+
+    // seed one of the nodes with snapshot
+    auto base_dir = n1.base_directory();
+    auto ntp = n1.ntp();
+
+    snapshot_metadata md{
+      .last_included_index = model::offset(128),
+      .last_included_term = model::term_id(64),
+      .latest_configuration = raft::group_configuration(
+        all_vnodes(), model::revision_id(0)),
+      .cluster_time = clock_type::time_point::min(),
+      .log_start_delta = offset_translator_delta(10),
+    };
+    co_await ss::recursive_touch_directory(n1.work_directory());
+    storage::simple_snapshot_manager snapshot_manager(
+      std::filesystem::path(n1.work_directory()),
+      storage::simple_snapshot_manager::default_snapshot_filename,
+      ss::default_priority_class());
+
+    co_await raft::details::persist_snapshot(snapshot_manager, md, iobuf{});
+
+    co_await n0.init_and_start(all_vnodes());
+    co_await n1.init_and_start(all_vnodes());
+    co_await n2.init_and_start(all_vnodes());
+
+    auto leader_id = co_await wait_for_leader(30s);
+    auto& leader_node = node(leader_id);
+    ASSERT_GT_CORO(leader_node.raft()->term(), md.last_included_term);
+    ASSERT_EQ_CORO(
+      leader_node.raft()->start_offset(),
+      model::next_offset(md.last_included_index));
+}