Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] rptest: handle errors from cloudv2 and rethrow proper error messages #12967

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[v23.2.x] rptest: handle errors from cloudv2 and rethrow proper error messages #12967

merged 1 commit into from
Aug 23, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #12915

@vbotbuildovich vbotbuildovich added this to the v23.2.x-next milestone Aug 23, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Aug 23, 2023
@savex savex marked this pull request as ready for review August 23, 2023 15:59
@savex
Copy link
Contributor

savex commented Aug 23, 2023

/cdt
rp_version=build
tests/rptest/tests/services_self_test.py::SimpleSelfTest

@savex savex self-assigned this Aug 23, 2023
@savex
Copy link
Contributor

savex commented Aug 23, 2023

https://buildkite.com/redpanda/redpanda/builds/35546

@savex savex requested a review from andrewhsu August 23, 2023 17:38
@savex
Copy link
Contributor

savex commented Aug 23, 2023

Build is green

andrewhsu
andrewhsu approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

i think the cdt test run is good enough since this PR only affects redpanda_cloud.py

@savex savex merged commit ebedc74 into redpanda-data:v23.2.x Aug 23, 2023
10 checks passed
@savex
Copy link
Contributor

savex commented Aug 23, 2023

LGTM

i think the cdt test run is good enough since this PR only affects redpanda_cloud.py

I just want to make sure I resolved conflicts properly.

@piyushredpanda piyushredpanda modified the milestones: v23.2.x-next, v23.2.7 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

Assignees

@savex savex

Labels
kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@vbotbuildovich @savex @andrewhsu @piyushredpanda