[v23.2.x] Txn sessions thrashing: expire all old txs instead of one at a time #13746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 3f92f12)
Refactor do_expire_old_tx to give more control to limit_init_tm_tx over error handling. (cherry picked from commit 1a17042)
(cherry picked from commit e0be00f)
When fetch_tx fails get_tx may remove a txn session and return tx_not_found; limit_init_tm_tx shouldn't propagate the error to the client because the method's intenion is the same (to remove oldest txn session when the txn cache is beyond its capacity). (cherry picked from commit 97b27f6)
Expiring one old txn sesison per new tx helps to maintain the txn sessions cache size at the capacity but it won't bring the cache size down if it's already beyond max_transactions_per_coordinator (it may happen when a user sets max_transactions_per_coordinator for the first time). Fixing it by bulk expiring. (cherry picked from commit 397e3c8)
Cleaning tx session cache blocks `init_producer_id` request until the size of the cache falls below the threshold. This commit makes it less disruptive by allowing `init_producer_id` to procced if its tx id is already in the cache so processing it doesn't make the situation worse. (cherry picked from commit 3d51861)
rystsov
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #13658