Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: specify relations using Model classes #266

Conversation

tomasz-zablocki
Copy link
Collaborator

Implementation of #265.

Adds an option to provide Model class as a first argument to oneToOne, fk and many or as to / through properties of oneToOne, fk and many overloads accepting an object argument.

@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #266 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   99.81%   99.81%   +<.01%     
==========================================
  Files          14       14              
  Lines        1073     1076       +3     
  Branches      211      212       +1     
==========================================
+ Hits         1071     1074       +3     
  Misses          2        2
Impacted Files Coverage Δ
src/fields.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb51fa...438fa4c. Read the comment docs.

@tomasz-zablocki tomasz-zablocki force-pushed the feature/model_class_as_relation_target branch from 6511810 to 3c6a756 Compare June 13, 2019 08:53
@tomasz-zablocki tomasz-zablocki force-pushed the feature/model_class_as_relation_target branch from 3c6a756 to 438fa4c Compare June 13, 2019 08:57
@haveyaseen haveyaseen merged commit b3d6cef into redux-orm:master Jun 13, 2019
@tomasz-zablocki tomasz-zablocki deleted the feature/model_class_as_relation_target branch June 13, 2019 10:19
@tomasz-zablocki tomasz-zablocki mentioned this pull request Aug 1, 2019
10 tasks
@haveyaseen haveyaseen added the type: Enhancement This intends to enhance the project. label Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement This intends to enhance the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants