-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mistake in kindOf.ts #4173
Fix mistake in kindOf.ts #4173
Conversation
In function miniKindOf: in other case, forget to invoke 'Object.prototype.toString' to get type
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bb863c5:
|
✔️ Deploy Preview for redux-docs ready! 🔨 Explore the source changes: bb863c5 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/6140ac671b607c00083ba696 😎 Browse the preview: https://deploy-preview-4173--redux-docs.netlify.app |
Same as #4160 |
Can you fix the formatting so tests can pass? |
@timdorr I'm not familiar with PR. I run 'npm run format' , maybe it will work this time |
Can you remove the package-lock.json change? You have an older version of npm installed. This should just be some code changes. |
@timdorr this time, I think it's OK |
Went with #4160 because it was first. Thanks for getting the ball rolling again! |
In function miniKindOf: in other case, forget to invoke 'Object.prototype.toString' to get type
Thanks for the PR!
To better assist you, please select the type of PR you want to create.
Click the "Preview" tab above, and click on the link for the PR type: