Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake in kindOf.ts #4173

Closed
wants to merge 2 commits into from
Closed

Conversation

anfengchen
Copy link

In function miniKindOf: in other case, forget to invoke 'Object.prototype.toString' to get type

Thanks for the PR!

To better assist you, please select the type of PR you want to create.

Click the "Preview" tab above, and click on the link for the PR type:

In function miniKindOf: in other case, forget to invoke 'Object.prototype.toString' to get type
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 14, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bb863c5:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Sep 14, 2021

✔️ Deploy Preview for redux-docs ready!

🔨 Explore the source changes: bb863c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/6140ac671b607c00083ba696

😎 Browse the preview: https://deploy-preview-4173--redux-docs.netlify.app

@anfengchen
Copy link
Author

Same as #4160

@timdorr
Copy link
Member

timdorr commented Sep 14, 2021

Can you fix the formatting so tests can pass?

@anfengchen
Copy link
Author

@timdorr I'm not familiar with PR. I run 'npm run format' , maybe it will work this time

@timdorr
Copy link
Member

timdorr commented Sep 14, 2021

Can you remove the package-lock.json change? You have an older version of npm installed. This should just be some code changes.

@anfengchen
Copy link
Author

@timdorr this time, I think it's OK

@timdorr
Copy link
Member

timdorr commented Sep 14, 2021

Went with #4160 because it was first. Thanks for getting the ball rolling again!

@timdorr timdorr closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants