💥 Promisify and add mongodb@5 support
#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidreedsy
requested changes
Mar 1, 2023
mongodb-queue.js
Outdated
| }) | ||
| }) | ||
| Queue.prototype.createIndexes = async function() { | ||
| var indexname = await this.col.createIndex({ deleted : 1, visible : 1 }) |
Collaborator
Author
There was a problem hiding this comment.
Mostly to stay consistent with what was there before, but maybe I can upgrade this too while we're here
mongodb-queue.js
Outdated
| Queue.prototype.createIndexes = async function() { | ||
| var indexname = await this.col.createIndex({ deleted : 1, visible : 1 }) | ||
| await this.col.createIndex({ack: 1}, {unique: true, sparse: true}) | ||
| await this.col.createIndex({deleted: 1}, {sparse: true}) |
There was a problem hiding this comment.
Shouldn't we have just
const [indexname] = await Promise.all([
this.col.createIndex({ deleted : 1, visible : 1 }),
this.col.createIndex({ack: 1}, {unique: true, sparse: true})
this.col.createIndex({deleted: 1}, {sparse: true})
])
mongodb-queue.js
Outdated
| // So: | ||
| // 1) add this message to the deadQueue | ||
| // 2) ack this message from the regular queue | ||
| // 3) call ourthis to return a new message (if exists) |
Collaborator
Author
There was a problem hiding this comment.
Ha bad find and replace 😅
dawidreedsy
reviewed
Mar 1, 2023
mongodb-queue.js
Outdated
Comment on lines
118
to
120
| if (this.deadQueue) { | ||
| // check the tries | ||
| if (msg.tries > this.maxRetries) { |
There was a problem hiding this comment.
Suggested change
| if (this.deadQueue) { | |
| // check the tries | |
| if (msg.tries > this.maxRetries) { | |
| if (this.deadQueue && msg.tries > this.maxRetries) { |
[`mongodb@5`][1] drops support for callbacks, which breaks this library, which is all written with callbacks. This is a **BREAKING** change which drops callback support from this library as well, and fully embraces promises through `async`/`await` syntax in both the library code and test code. This allows us to support both `mongodb@4` and `mongodb@5`. [1]: https://github.com/mongodb/node-mongodb-native/releases/tag/v5.0.0
dawidreedsy
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mongodb@5drops support for callbacks, which breaks this library, which is all written with callbacks.This is a BREAKING change which drops callback support from this library as well, and fully embraces promises through
async/awaitsyntax in both the library code and test code.This allows us to support both
mongodb@4andmongodb@5.