From 6140712b138f5b1390b1f3203a2cb5a664455be2 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 28 Dec 2018 08:55:38 -0800 Subject: [PATCH] test: remove try/catch in common.isMainThread Refactor common.isMainThread. PR-URL: https://github.com/nodejs/node/pull/25249 Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca --- test/common/index.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/test/common/index.js b/test/common/index.js index 5ac79f4998acc8..5d9a4b31e36534 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -39,12 +39,11 @@ const noop = () => {}; const hasCrypto = Boolean(process.versions.openssl); const isMainThread = (() => { - try { + if (require('module').builtinModules.includes('worker_threads')) { return require('worker_threads').isMainThread; - } catch { - // Worker module not enabled → only a single main thread exists. - return true; } + // Worker module not enabled → only a single main thread exists. + return true; })(); // Check for flags. Skip this for workers (both, the `cluster` module and