Caching optimization

[jokklan]

The way page caching works in refinery now (in master) is that every time a refinery page is updated/created/destroyed, all refinerycms cached pages is removed. This works fine for refinery pages in a simple application, but it would be nice to have some form of application interface so engines could take advantage of this functionality too, without having to rewrite it from scratch.

When a page is updated, is the memory cache (only used for fragment caching as far as i can tell?) also cleared. I can only find one place where fragment caching is used (pages record on admin pages index page) but fragment caches should auto expire based on the key, not be cleared manually.

Also when we are on the topic: why don't refinery use the normal rails methods for page caching? All pages are stored after the URL, so their should not be any problems with colliding pages even without the refinery/cache/pages name spaced folder.

I know this is a lot of questions, but caching is a important part of any website, and i feel that it how been a bit left out in refinery so far. However with #2083, has caching been much improved and i would love to help continuing to improve caching in refinery, and hopefully have a simple effective and tested caching implementation ready to version 2.1.0 :) !

[parndt]

@jokklan would love your help on this issue. I think that the way that caching is currently done is a result of cargo-culting over and over ;-)

Excited that you want to tackle this. Please re-invent caching as you see fit. If you could do this soon then even better because we have a vision to release 2.1.0 in the close future and it would be great to ship it with sane caching. :-)

Even better is some level of testing around caching - currently there's none.

Thanks again 👍

[jokklan]

Im already started ;)!

I will return when i have something to show. Btw, is it possible to change a issue to a pull request, or do i need to add a new pull request ?

[parndt]

You can change it using the API.. I think the hub package can do this. Otherwise, feel free to just open a pull request, link to this issue and close this issue if you like.