Refactored many internals of pages to centralize page cache expiration... #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also removed |
| delegate :cache, :to => Rails | ||
|
|
||
| def cache_dir_valid? | ||
| @cache_dir.present? && cache_dir_path.directory? |
There was a problem hiding this comment.
Use attr_reader for cache_dir here and on line 22. In case cache_dir needs to change in the feature we'll have to change it only in one place.
…n so that it's easy to stub for specs.
ugisozols
added a commit
that referenced
this pull request
Dec 21, 2012
Refactored many internals of pages to centralize page cache expiration...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that it's easy to stub for specs.
I like this, it seems to make the specs run faster and is generally a cleaner architecture that moves things out of Page that don't belong there!