Fix #3218 regression on sitemap: don't duplicate locale in url

[bricesanchez]

Fix #3218 regression: don't duplicate locale in url and refactor the builder to be more readable

Since this PR, i have problems on sitemap:

[...]
<url>
<loc>
http://localhost:3000/en/en/rate_requests/new
</loc>
<lastmod>2016-09-01</lastmod>
</url>
<url>
<loc>http://localhost:3000/en/forms</loc>
<lastmod>2016-09-01</lastmod>
</url>
<url>
<loc>http://localhost:3000/en/about-us</loc>
<lastmod>2016-09-01</lastmod>
</url>
<url>
<loc>http://localhost:3000/en/en/jobs</loc>
<lastmod>2016-09-01</lastmod>
</url>
<url>
<loc>http://localhost:3000/en/en</loc>
<lastmod>2016-07-20</lastmod>
</url>
[...]

After the fix:

[...]
<url>
<loc>http://localhost:3000/en/rate_requests/new</loc>
<lastmod>2016-09-01</lastmod>
</url>
<url>
<loc>http://localhost:3000/en/forms</loc>
<lastmod>2016-09-01</lastmod>
</url>
<url>
<loc>http://localhost:3000/en/about-us</loc>
<lastmod>2016-09-01</lastmod>
</url>
<url>
<loc>http://localhost:3000/en/jobs</loc>
<lastmod>2016-09-01</lastmod>
</url>
<url>
<loc>http://localhost:3000/en</loc>
<lastmod>2016-07-20</lastmod>
</url>
[...]

[bricesanchez]

@sintro Could you test this PR ?

[sintro]

Just checked, your patch works fine for my cases, so it breaks nothing. But I also did not have such problems, probably, you get it when the path of page has manually set /language/ part? I think now with this PR everything is fine!

One thing about this sitemap generation: what about filtering out the pages with that locales, which don't have translations for that language (for example, empty body or title or both)?

[bricesanchez]

Just checked, your patch works fine for my cases, so it breaks nothing. But I also did not have such problems, probably, you get it when the path of page has manually set /language/ part? I think now with this PR everything is fine!

The sitemap problem was on extensions urls, no pages url.

One thing about this sitemap generation: what about filtering out the pages with that locales, which don't have translations for that language (for example, empty body or title or both)?

It's already done by the in_menu scope:

refinerycms/pages/app/models/refinery/page.rb

Line 121 in 2c3b7c3

def in_menu

[sintro]

It's already done by the in_menu scope

Strangely, but I always get all of the pages with all of frontend_locales... Even for pages, which even does not have that locale symbol in Pages section in admin panel (so, there are no title and no body).

[mhtremblay]

Is there something missing to merge this PR?

[sintro]

@mhtremblay everything is fine. At least, new sitemap.xml.erb is better than older.

[mhtremblay]

Can someone merge this PR plz?

[mhtremblay]

page.url.merge({only_path: false, locale: locale})