Bugfix #2915: assign cancel_url path in engine generator _form partial #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix Cancel button who did not work on non-posts after switching languages
bricesanchez
force-pushed
the
bugfix/2915/cancel-url
branch
from
c9a25c3
to
44f07d0
Compare
parndt
approved these changes
Mar 9, 2018
bricesanchez
added a commit
that referenced
this pull request
Apr 10, 2018
#3351 will introduce a regression but setting the cancel_url with the model name pluralize instead of the namespace name
bricesanchez
added a commit
that referenced
this pull request
Apr 10, 2018
bricesanchez
added a commit
that referenced
this pull request
Apr 11, 2018
bricesanchez
added a commit
that referenced
this pull request
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix Cancel button who did not work on non-posts after switching languages