Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add step prop for rx.Slider component #1639

Closed
masenf opened this issue Aug 21, 2023 · 0 comments · Fixed by #1643
Closed

Add step prop for rx.Slider component #1639

masenf opened this issue Aug 21, 2023 · 0 comments · Fixed by #1643
Labels
enhancement Anything you want improved good first issue Good for newcomers

Comments

@masenf
Copy link
Collaborator

masenf commented Aug 21, 2023

The Slider component is missing a crucial prop, step, which controls where the "thumb" stops along the track.

image

See https://chakra-ui.com/docs/components/slider/props

Additionally the min_steps_between_thumbs prop should be removed, as that is only defined on the rx.RangeSlider.
@masenf masenf added enhancement Anything you want improved good first issue Good for newcomers labels Aug 21, 2023
muddi900 added a commit to muddi900/pynecone that referenced this issue Aug 21, 2023
@muddi900
Added the step prop to Slider[Issue reflex-dev#1639]
30b586c
@muddi900 muddi900 mentioned this issue Aug 21, 2023
Merged
3 tasks
picklelo pushed a commit that referenced this issue Aug 21, 2023
@muddi900
Added the step prop to Slider[Issue #1639] (#1643)
0ce77c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Anything you want improved good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added the step prop to Slider[Issue #1639] muddi900/pynecone
1 participant
@masenf