Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Redis with an open-source alternative due to licensing changes #2901

Open
jq6l43d1 opened this issue Mar 22, 2024 · 5 comments
Open

Comments

@jq6l43d1
Copy link

Describe the bug
Redis, the popular in-memory data structure store, has recently changed its licensing model from open-source to a proprietary license. I believe this change conflicts with this project's principles. Additionally, it may also conflict with our individual principles and values, as many of us strongly believe in the importance of free and open-source software.

To address this issue, we should replace Redis with an open-source alternative.

I propose that we replace Redis with KeyDB. Which is a fork of Redis that is faster and free as in freedom. However, there are other open-source alternatives available as well

@masenf
Copy link
Collaborator

masenf commented Mar 22, 2024

Thanks for raising this issue. I agree that the licensing changes in redis are not ideal.

@jq6l43d1
Copy link
Author

The Linux foundation has launched an open-source fork of Redis called Valkey. https://github.com/valkey-io/valkey

@ericwb
Copy link
Contributor

ericwb commented May 14, 2024

Currently Reflex isn't using the latest version of Redis anyway. As of today, it uses version 5.0.4 (">=4.3.5,<6.0"). The license change was made in Redis 7.2.4. Valkey is at 7.2.5. So maybe there are some compatibility issues using Redis 6+

@ericwb
Copy link
Contributor

ericwb commented May 14, 2024

For cases like this, I would recommend setting up dependency-review-action to avoid accidentally including a lessor-permissive licensed dependency.

ericwb added a commit to ericwb/reflex that referenced this issue May 14, 2024
This change will add a new action to scan the dependency's licenses
for any that may not be allowed for this project.

The pip-licenses command was run to get a dump of all the licenses
associated with this repo and put into the allow-licenses list.
Normally, you might only want to use deny-licenses list, but for
packages like Redis, there is no defined SPDX identifier for it.

Note: this list will require future maintenance as dependencies get
added that are not already in the allow list.

https://spdx.org/licenses/
https://github.com/raimon49/pip-licenses

Related to issue reflex-dev#2901

Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
masenf pushed a commit that referenced this issue May 15, 2024
…#3306)

This change will add a new action to scan the dependency's licenses
for any that may not be allowed for this project.

The pip-licenses command was run to get a dump of all the licenses
associated with this repo and put into the allow-licenses list.
Normally, you might only want to use deny-licenses list, but for
packages like Redis, there is no defined SPDX identifier for it.

Note: this list will require future maintenance as dependencies get
added that are not already in the allow list.

https://spdx.org/licenses/
https://github.com/raimon49/pip-licenses

Related to issue #2901

Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
benedikt-bartscher pushed a commit to benedikt-bartscher/reflex that referenced this issue May 16, 2024
…reflex-dev#3306)

This change will add a new action to scan the dependency's licenses
for any that may not be allowed for this project.

The pip-licenses command was run to get a dump of all the licenses
associated with this repo and put into the allow-licenses list.
Normally, you might only want to use deny-licenses list, but for
packages like Redis, there is no defined SPDX identifier for it.

Note: this list will require future maintenance as dependencies get
added that are not already in the allow list.

https://spdx.org/licenses/
https://github.com/raimon49/pip-licenses

Related to issue reflex-dev#2901

Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
@Xynonners
Copy link

The Linux foundation has launched an open-source fork of Redis called Valkey. https://github.com/valkey-io/valkey

I second valkey, switched all my redis backends to it and works great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants