Improve event processing performance #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Maybe use error level for production and debug level for debug mode? |
Made this update |
Alek99
approved these changes
Dec 22, 2022
| @@ -695,18 +637,3 @@ async def test_process_event_substate(TestState, ChildState, GrandchildState): | |||
| "test_state.child_state.grandchild_state": {"value2": "new"}, | |||
| "test_state": {"sum": 3.14, "upper": ""}, | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Nice I think it won't be a big deal getting rid of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getattrandsetattrlogic previously included to handle some edge cases of substates accessing parent state vars. From now on, that use case will have to be more explicit.critical- we had left it asdebugwhich may also have impacted performancePerformance after this change:
Compared to before: #153