Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template version check #164

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Add template version check #164

merged 1 commit into from
Dec 22, 2022

Conversation

picklelo
Copy link
Contributor

  • Add pcversion.txt file in the template - we should update this whenever we change the template.
  • If the app was initialized with an old version, ask the user to run pc init again.
  • Update the poetry project to v0.1.11

@picklelo picklelo linked an issue Dec 22, 2022 that may be closed by this pull request
@picklelo picklelo requested a review from Alek99 December 22, 2022 03:28
@@ -0,0 +1 @@
0.1.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the reason for using a txt file vs having a variable in the constants.py

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait nvm I get it because if they update pc the web folder could be made from the older one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I tried the config way but this seemed easier

@Alek99 Alek99 self-requested a review December 22, 2022 03:45
Copy link
Member

@Alek99 Alek99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me nicely done clever with the txt file

@picklelo picklelo merged commit 0bc09dc into main Dec 22, 2022
@picklelo picklelo deleted the nikhil/pcversion branch December 22, 2022 04:05
ACucos1 pushed a commit to ACucos1/rd-pynecone that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added ReInit to detect new version
2 participants