Allow underscores in routes #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElijahAhianyo
changed the title
masenf
previously approved these changes
Aug 30, 2023
Yeah, could add that to this PR |
ElijahAhianyo
force-pushed
the
elijah/underscores_in_routes
branch
from
e0f484c to
21d01b5
Compare
picklelo
reviewed
Sep 6, 2023
Previously, we convert underscores in routes to hyphens
picklelo
requested changes
Sep 7, 2023
ElijahAhianyo
force-pushed
the
elijah/underscores_in_routes
branch
from
8b015b6 to
8f5b1e7
Compare
masenf
reviewed
Sep 7, 2023
integration/test_dynamic_routes.py
Outdated
| app_harness_env: Type[AppHarness], tmp_path_factory | ||
| app_harness_env: Type[AppHarness], tmp_path_factory |
There was a problem hiding this comment.
i don't understand why these blocks are all indented more...
There was a problem hiding this comment.
probably as a result of running precommits (black), not typically sure why those parts are affected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the need for converting underscores to hyphens in routes, which was previously implemented. The goal of this change is to enhance the flexibility of route naming by allowing both underscores and hyphens to coexist without the need for any conversions. This PR proposes to remove the underscore-to-hyphen conversion logic, allowing developers to freely choose between these two naming conventions for routes.
Changes Made
Motivation
Impact
With this change, developers are free to use both underscores and hyphens as they see fit in route names.
The removal of the underscore-to-hyphen conversion ensures that developers can choose their preferred naming convention without the need for special handling.
Existing routes with either underscores or hyphens in their names will continue to function as expected.