Proper serialization for chained Event payloads #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that fix_events converts the arg types correctly
ensure the value is a real python boolean
Calling an EventHandler returns an EventSpec with the function call arguments encoded as `Var`. This works fine when formatting the Var into an event via `format.format_event`, however when directly creating a payload and serializing the entire Event to send to the client to be queued, the `fix_events` function was just taking the "name" of the var, which is a json-encoded value. In order to properly serialize the event payload, these Var args need to be decoded back into their python values, so that the payload as a whole can be re-serialized. Implement a `Var._decode` operation, which operates (mostly) as the inverse of `Var.create`. This is an underscore method, because it actually doesn't return another Var, but instead the real python value that the Var is created from. Fix #1722
Yikes, these tests had codified the bad serialization in their expectations; now that we serialize correctly, update the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling an
EventHandlerreturns anEventSpecwith the function call arguments encoded asVar.This works fine when formatting the
Varinto an event viaformat.format_event, however when directly creating a payload and serializing the entireEventto send to the client to be queued, thefix_eventsfunction was just taking the "name" of theVar, which is a json-encoded value.In order to properly serialize the event payload, these
Varargs need to be decoded back into their python values, so that the payload as a whole can be re-serialized properly.Implement a
Var._decodeoperation, which operates (mostly) as the inverse ofVar.create. This is an underscore method, because it actually doesn't return anotherVar, but instead the real python value that theVaris created from.Fix #1722
Add/update unit and integration test cases in this area.