Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track var dependencies in comprehensions and nested functions #1728

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Track var dependencies in comprehensions and nested functions #1728

merged 5 commits into from
Sep 4, 2023

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Aug 31, 2023 •
edited
Loading

Improve tracking of rx.cached_var dependencies when the function uses nested functions and list comprehensions.

Fix #1709

picklelo
picklelo previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the unit tests :)

@picklelo picklelo merged commit b44c217 into main Sep 4, 2023
34 checks passed
@masenf masenf deleted the masenf/cached-var-comprehensions branch September 7, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rx.cached_var does not find dependencies inside a list comprehension
2 participants
@masenf @picklelo