state: get_value unwraps MutableProxy first
#1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calling `get_value` triggers pydantic serialization semantics, which recursively serializes `Base` instances in a structure. However, this only works if the `Base` subclasses are not wrapped in `MutableProxy`, so explicitly unwrap the proxy in order to correctly serialize the state inside `dict()` Fix #1886
picklelo
previously approved these changes
Sep 29, 2023
|
Looks good, can merge once the conflict is resolved |
picklelo
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calling
get_valuetriggers pydantic serialization semantics, which recursively serializesBaseinstances in a structure. However, this only works if theBasesubclasses are not wrapped inMutableProxy, so explicitly unwrap the proxy in order to correctly serialize the state insidedict()Fix #1886