state: subclass of MutableState must return _mark_dirty return value #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the methods actually return useful values, like `pop`, so the return value must be passed through after marking dirty. Previous fix #1876 corrected this issue for normal event handlers using MutableProxy. This fix is needed for background tasks that use ImmutableMutableProxy.
picklelo
approved these changes
Oct 2, 2023
Lendemor
approved these changes
Oct 2, 2023
| @@ -1656,6 +1656,9 @@ async def background_task(self): | |||
| pass # update proxy instance | |||
|
|
|||
| async with self: | |||
| # Methods on ImmutableMutableProxy should return their wrapped return value. | |||
| assert self.dict_list.pop("foo") is not None | |||
There was a problem hiding this comment.
Should we check against the actual value of foo rather than not None ?
There was a problem hiding this comment.
might not hurt. i'll add it to a subsequent PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the methods actually return useful values, like
pop, so the return value must be passed through after marking dirty.Previous fix #1876 corrected this issue for normal event handlers using MutableProxy. This fix is needed for background tasks that use ImmutableMutableProxy.