Lendemor/fix backward compat of menu api #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
reviewed
Oct 5, 2023
| if not items: | ||
| items = [] | ||
| children.append(MenuList.create(*items)) | ||
| children.append(MenuList.create(items=items)) |
There was a problem hiding this comment.
what is the advantage of adding another arg, items, here?
There was a problem hiding this comment.
It's to avoid conflict with the "manual" API where users defined every component by themselves.
(Like in reflex-web where the menu items in the navbar are defined manually.)
masenf
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #1905, some issue in MenuList cause hydration error in
reflex-web