Update Deprecations #1927
Merged
Update Deprecations #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
previously approved these changes
Oct 5, 2023
ElijahAhianyo
commented
Oct 5, 2023
| @@ -241,7 +241,7 @@ def _create_event_chain( | |||
| feature_name="EventChain", | |||
| reason="to avoid confusion, only use yield API", | |||
| deprecation_version="0.2.8", | |||
| removal_version="0.2.9", | |||
| removal_version="0.3.1", | |||
There was a problem hiding this comment.
pushing the deprecation dates back as it will require additional testing
| @@ -537,7 +537,7 @@ def call_event_handler( | |||
| feature_name="EVENT_ARG API for triggers", | |||
| reason="Replaced by new API using lambda allow arbitrary number of args", | |||
| deprecation_version="0.2.8", | |||
| removal_version="0.2.9", | |||
| removal_version="0.3.1", | |||
There was a problem hiding this comment.
pushing this back for the same reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update Deprecation versions and pushed the deprecation versions of deprecated features that require extra testing back