-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added base template + improve templating code #1937
Conversation
I'll fix the code, I know why its failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks nice, but the code structure needs some rework to maximize developer experience and push people toward more maintainable code.
rx.menu_item("Home"), | ||
rx.menu_divider(), | ||
rx.menu_item("About"), | ||
rx.menu_item("Contact"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to make these actually work?
rx.menu_item("About", on_click=rx.redirect("/about")),
rx.menu_item(rx.link("Contact", href="/contact")),
The rx.link
one only works when you click on the text itself, but the on_click
one seems a bit unusual too. Need example so users know what to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few different link example, setting width to 100% fixed the only working when clicking text
|
Should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is excellent, looks good and well organized
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
After these steps, you're ready to open a pull request.