Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 0.3.0 deprecated features #1947

Merged
merged 12 commits into from
Oct 19, 2023

Conversation

ElijahAhianyo
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@ElijahAhianyo ElijahAhianyo changed the title [WIP]Remove deprecated features Remove 0.3.0 deprecated features Oct 13, 2023
@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review October 13, 2023 10:26
Lendemor
Lendemor previously approved these changes Oct 13, 2023
reflex/event.py Outdated Show resolved Hide resolved
reflex/utils/format.py Outdated Show resolved Hide resolved
Lendemor
Lendemor previously approved these changes Oct 16, 2023
@ElijahAhianyo ElijahAhianyo force-pushed the elijah/remove-v0.3.0-deprecated-features branch from 8487fc3 to bcebb63 Compare October 16, 2023 11:03
@ElijahAhianyo
Copy link
Collaborator Author

Integration tests need reflex-dev/reflex-web#226 to pass

ElijahAhianyo and others added 4 commits October 16, 2023 11:14
The path can and should be specified in the options dict. If path is not
provided in options, then it is assumed to be "/".

Adjust assertions in tests to account for default path.
@picklelo picklelo merged commit 06bdf9e into main Oct 19, 2023
37 checks passed
@masenf masenf deleted the elijah/remove-v0.3.0-deprecated-features branch October 22, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants