convert initialEvents to a function #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that hydrateClientStorage is being called fresh each time the page is hydrated to allow recently set local storage / cookie vars to be sent to the backend. Fix #1979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the
initialEventslist into a function that returns the list of initial events for two advantages:.map((e) => ...e)to copy the listhydrateClientStorageeach time to ensure that the local storage and cookie hydrate dict contains the most up to date value.Fix #1979
Add a new app harness test simulating the login flow that reproduced this issue initial. Since some additional refactoring is coming around on_load and hydrate, I wanted to be sure this flow does not regress after it is fixed.