Stop double compiles in dev mode #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lendemor
reviewed
Oct 17, 2023
Lendemor
reviewed
Oct 17, 2023
masenf
reviewed
Oct 17, 2023
Comment on lines
+593
to
+594
| if os.environ.get(constants.SKIP_COMPILE_ENV_VAR) == "yes": | ||
| return False |
There was a problem hiding this comment.
can we just get rid of this? i don't think it was being used anywhere else
There was a problem hiding this comment.
I think this is used in other places in reflex.py. For example we call _skip_compile() in db_init and migrate. Agreed we should have only one way to do this though as this could be a bit messy to have two methods.
masenf
previously approved these changes
Oct 19, 2023
Lendemor
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
.web/.nocompilefunction that stops the first initial compile on the backend process in dev mode. After the first skip, the file is deleted, enabling hot reload to keep working.