Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radix Themes style notation fix #2025

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Radix Themes style notation fix #2025

merged 2 commits into from
Oct 24, 2023

Conversation

ElijahAhianyo
Copy link
Collaborator

@ElijahAhianyo ElijahAhianyo commented Oct 24, 2023 •
edited
Loading

Fix for a bug where sx is used for radix style props instead of style

masenf
masenf requested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much simpler approach, very nice

reflex/components/component.py Outdated Show resolved Hide resolved
@ElijahAhianyo @masenf
Update reflex/components/component.py
47932f9 
Co-authored-by: Masen Furer <m_github@0x26.net>
@picklelo picklelo merged commit d785bd9 into main Oct 24, 2023
37 checks passed
@picklelo picklelo deleted the elijah/radix-style-notation branch November 1, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElijahAhianyo @masenf @picklelo