-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI improvements #2026
CLI improvements #2026
Conversation
…eploy; remove other logs commands
@@ -71,7 +71,7 @@ def _zip( | |||
target: The target zip file. | |||
root_dir: The root directory to zip. | |||
exclude_venv_dirs: Whether to exclude venv directories. | |||
exclude_sqlite_db_files: Whether to exclude sqlite db files. | |||
upload_db_file: Whether to include local sqlite db files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackie-pc I'm renaming and flipping the use of its value (before exclude, now include) since we expose this option to use. It's a more friendly name I think.
reflex/utils/hosting.py
Outdated
@@ -448,14 +449,18 @@ def deploy( | |||
) | |||
# If the server explicitly states bad request, | |||
# display a different error | |||
if response.status_code == HTTPStatus.BAD_REQUEST: | |||
raise ValueError(response.json()["detail"]) | |||
assert ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Use of assert in production code is generally not recommended. https://snyk.io/blog/the-dangers-of-assert-in-python/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh, I did not know that. I've replaced all my assertions with manual if/elses.
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
After these steps, you're ready to open a pull request.
--help
the options not meant for public users for all hosting related commands.reflex deployments logs
command to show user logs.