Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-1042] Hosting CLI: check the user selected app name #2102

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

martinxu9
Copy link
Contributor

@martinxu9 martinxu9 commented Oct 31, 2023

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

  • Check the user input against any characters not allowed in domain name, raise an error
  • Clarify it is domain name safe characters when prompt for app name
  • Remove the access token validation in hosting.deploy. It is not the first call to hosting server. Token is already validated. This can improve the speed on user with slow internet.
  • If user input contains upper cases, print message informing user that the name is automatically converted to lower cases
  • Example 1:
image - Example 2: image

@martinxu9 martinxu9 requested a review from Alek99 October 31, 2023 20:58
@martinxu9 martinxu9 changed the title Hosting CLI: check the user selected app name [REF-1042] Hosting CLI: check the user selected app name Oct 31, 2023
@martinxu9 martinxu9 requested a review from picklelo November 1, 2023 19:16
@picklelo picklelo merged commit 4a52662 into main Nov 2, 2023
37 checks passed
@martinxu9 martinxu9 deleted the martinxu9/cli-instance-name-prompt branch November 2, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants