Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lendemor/next 14 #2142

Merged
merged 15 commits into from
Nov 13, 2023
Merged

Lendemor/next 14 #2142

merged 15 commits into from
Nov 13, 2023

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Nov 7, 2023

upgrade nextjs version to 14.0.1

@Lendemor Lendemor marked this pull request as draft November 7, 2023 17:36
@Lendemor Lendemor marked this pull request as ready for review November 8, 2023 17:30
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works well for me except for the sitemap comment

reflex/constants/installer.py Outdated Show resolved Hide resolved
reflex/utils/prerequisites.py Show resolved Hide resolved
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed reflex-web to the hosting service with this version of reflex and it did work. But i agree there is something funky about the sitemap generation: https://pcweb-next14.reflex.run/sitemap-0.xml

reflex/constants/base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me! Just some small comments

reflex/utils/build.py Show resolved Hide resolved
reflex/utils/console.py Outdated Show resolved Hide resolved
reflex/utils/prerequisites.py Outdated Show resolved Hide resolved
reflex/utils/prerequisites.py Show resolved Hide resolved
@Lendemor Lendemor requested review from picklelo and masenf November 13, 2023 17:01
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@picklelo picklelo merged commit 39cc1b2 into main Nov 13, 2023
45 checks passed
@masenf masenf deleted the lendemor/next_14 branch December 6, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants