Separate get_hooks and get_hooks_internal for stable output
#2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When downstream component wrappers depend on State when writing hooks, they need to be assured that all internal hooks (events, var hooks, memoized handlers, etc) will be rendered prior to user-defined hooks. This also makes it less likely for downstream components to feel the need to overwrite `get_hooks` (no underscore) directly and break internal functioning of Reflex components.
picklelo
previously approved these changes
Mar 13, 2024
…-output Fix conflicts moving from radix/chakra form submit to base el form submit
picklelo
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downstream component wrappers depend on State when writing hooks, they need to be assured that all internal hooks (events, var hooks, memoized handlers, etc) will be rendered prior to user-defined hooks.
This also makes it less likely for downstream components to feel the need to overwrite
get_hooks(no underscore) directly and break internal functioning of Reflex components.