Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry refactor + unit tests #2786

Merged
merged 22 commits into from
Mar 13, 2024
Merged

telemetry refactor + unit tests #2786

merged 22 commits into from
Mar 13, 2024

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Mar 5, 2024

No description provided.

@Lendemor Lendemor marked this pull request as ready for review March 6, 2024 18:16
picklelo
picklelo requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments, and looks like the tests are failing

reflex/utils/telemetry.py Outdated Show resolved Hide resolved
reflex/utils/telemetry.py Outdated Show resolved Hide resolved
reflex/utils/telemetry.py Outdated Show resolved Hide resolved
@masenf masenf closed this Mar 12, 2024
@masenf masenf reopened this Mar 12, 2024
@Lendemor Lendemor requested a review from picklelo March 13, 2024 15:52
@picklelo picklelo merged commit 92db402 into main Mar 13, 2024
47 checks passed
@masenf masenf mentioned this pull request Mar 19, 2024
Closed
@picklelo picklelo deleted the lendemor/telemetry_unit_tests branch August 21, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lendemor @picklelo @masenf