Get client_ip from asgi.scope
#2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like REMOTE_ADDR is always 127.0.0.1, which is not super useful when trying to figure out where the websocket connection is originating from. Of course this isn't a silver bullet because most-likely the WS will be passed through a reverse proxy anyway... in that case, the client IP is likely in the headers under `x_forwarded_for`
picklelo
reviewed
Mar 11, 2024
reflex/app.py
Outdated
| @@ -1146,7 +1146,7 @@ async def on_event(self, sid, data): | |||
| } | |||
|
|
|||
| # Get the client IP | |||
| client_ip = environ["REMOTE_ADDR"] | |||
| client_ip = environ["asgi.scope"]["client"][0] | |||
There was a problem hiding this comment.
Do we want to add any get or try/catch here, or will these key lookups always work? We should avoid crashing outside the event loop is my concern
There was a problem hiding this comment.
yeah i can try/catch it. i didn't because we didn't before, but this is multiple levels of derefs, so more could go wrong
picklelo
previously approved these changes
Mar 13, 2024
picklelo
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like REMOTE_ADDR is always 127.0.0.1, which is not super useful when trying to figure out where the websocket connection is originating from.
Of course this isn't a silver bullet because most-likely the WS will be passed through a reverse proxy anyway... in that case, the client IP is likely in the headers under
x_forwarded_for