Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove width prop from rx.select #2835

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Remove width prop from rx.select #2835

merged 2 commits into from
Mar 13, 2024

Conversation

picklelo
Copy link
Contributor

Radix select doesn't have this prop, and it breaks the default styling. Closes #2824

@picklelo picklelo force-pushed the nikhil/select-width-rm branch from 217345f to 9358cb0 Compare March 11, 2024 22:39
@picklelo picklelo merged commit d14292d into main Mar 13, 2024
45 checks passed
@masenf masenf mentioned this pull request Mar 18, 2024
Closed
masenf added a commit that referenced this pull request Mar 18, 2024
@masenf
Revert "Remove width prop from rx.select (#2835)"
f151857 
This reverts commit d14292d.
masenf added a commit that referenced this pull request Mar 18, 2024
@masenf
HighLevelSelect: pass flex_shrink prop to SelectTrigger (#2876)
f446d06 
* Revert "Remove width prop from rx.select (#2835)"

This reverts commit d14292d.

* HighLevelSelect: pass flex_shrink prop to SelectTrigger

This allows the high level select to have width="100%" and also shrink-to-fit inside a parent container.

Fix #2824, kind of
masenf added a commit that referenced this pull request Mar 19, 2024
@masenf
HighLevelSelect: pass flex_shrink prop to SelectTrigger (#2876)
1a75290 
* Revert "Remove width prop from rx.select (#2835)"

This reverts commit d14292d.

* HighLevelSelect: pass flex_shrink prop to SelectTrigger

This allows the high level select to have width="100%" and also shrink-to-fit inside a parent container.

Fix #2824, kind of
@masenf masenf deleted the nikhil/select-width-rm branch April 24, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rx.select width applies incorrectly when stacked horizontally
2 participants
@picklelo @masenf