better default title for seo (also remove default description) #2844

Lendemor · 2024-03-12T11:56:07Z

Adding a new page without passing a title will now use the method make_default_page_title by passing app_name and route .

Example:

$ format.make_default_page_title("my_beautiful_app", "third_page")
> 'My Beautiful App : Third Page'

reflex/constants/route.py

reflex/utils/format.py

Alek99 · 2024-03-12T19:39:26Z

Testing on the dev reflex web see if this fixes the description problem

reflex/app.py

better default title for seo (also remove default description)

089bc48

picklelo reviewed Mar 12, 2024

View reviewed changes

reflex/constants/route.py Outdated Show resolved Hide resolved

reflex/utils/format.py Outdated Show resolved Hide resolved

Lendemor added 2 commits March 12, 2024 20:14

change separator in default title

0e33f02

improve_to_title_case

591eced

fix small mistake

0bab56c

picklelo reviewed Mar 12, 2024

View reviewed changes

reflex/app.py Show resolved Hide resolved

Lendemor added 2 commits March 13, 2024 00:58

don't set any description if not passed as arg

ad21c86

fix compiler for description

b95b2ef

Alek99 self-requested a review March 13, 2024 00:44

Alek99 previously approved these changes Mar 13, 2024

View reviewed changes

Lendemor dismissed Alek99’s stale review via b95b2ef March 13, 2024 01:50

Alek99 self-requested a review March 13, 2024 18:18

Alek99 approved these changes Mar 13, 2024

View reviewed changes

Alek99 merged commit e5fc5f9 into main Mar 13, 2024
47 checks passed

picklelo deleted the lendemor/better_default_seo branch August 21, 2024 20:42

Provide feedback