Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default styling for rx.upload #3017

Closed
wants to merge 3 commits into from
Closed

Conversation

AmanSal1
Copy link
Contributor

@AmanSal1 AmanSal1 commented Apr 5, 2024

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.
Adding a default styling to the rx.upload method 

b. Describe your changes.
I have implemented a logic to provide default styling. Whenever a user employs rx.upload, default styling will be applied if 
not explicitly mentioned. Users can override these defaults with custom styles if desired.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).
Fixes : #2967 

@AmanSal1
Copy link
Contributor Author

AmanSal1 commented Apr 5, 2024

@picklelo I have implemented logic to apply default styling, and I would like you to review it. I have verified that users can directly override the existing default styles. However, I haven't written any test cases yet. Once you confirm, we can proceed to add the necessary test cases .

@Lendemor
Copy link
Collaborator

Lendemor commented May 5, 2024

We merged #3035 doing styling for rx.upload

@Lendemor Lendemor closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants