Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added serializer for enums #3058

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

wassafshahzad
Copy link
Contributor

@wassafshahzad wassafshahzad commented Apr 9, 2024

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

Added serializers for Enums

Linked Issue

closes #3042

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. i think adding the plural to the docstring will fix the CI

reflex/utils/serializers.py Outdated Show resolved Hide resolved
Co-authored-by: Masen Furer <m_github@0x26.net>
@wassafshahzad
Copy link
Contributor Author

looks good. i think adding the plural to the docstring will fix the CI

Sorry, I went out otherwise I would have fixed it.

@picklelo picklelo merged commit 9073a27 into reflex-dev:main Apr 10, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State does not enums datatype
3 participants