Fix annotated EventHandler #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the args_spec is attached to the __metadata__ in a supported way
martinxu9
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_GenericAliasis a private implementation detail, and when we attach theargs_specto it as an attribute, it seems to attach it to the class itself, and get overwritten every time the annotation is used.Instead, reimplement this mechanism using the standard
AnnotatedAPI, which is well supported since 3.9 and is designed for attaching extra information to a type hint.Update the test cases for this feature to actually ensure the resulting args_spec is identical when defined via
get_event_triggers.