Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add color dalle code example #3108

Merged
merged 4 commits into from
Apr 20, 2024
Merged

add color dalle code example #3108

merged 4 commits into from
Apr 20, 2024

Conversation

tgberkeley
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@tgberkeley tgberkeley requested a review from Alek99 April 18, 2024 00:41
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial Impression


should openai_client = openai.OpenAI() be included in the blue box?


Use self. to call state class variables

Suggest "Use self. to access state variables for the current session"


Use State. when referring to state class variables (do not use self.)

Suggest "Use State. to render state vars and reference evnet handlers"


I think under the backend section we should add "Code runs directly on the server". And under the frontend section we should add "Code translated to React/JS runs in the user's browser"

@tgberkeley tgberkeley requested a review from masenf April 18, 2024 18:22
README.md Outdated Show resolved Hide resolved
Co-authored-by: Masen Furer <m_github@0x26.net>
@tgberkeley tgberkeley requested a review from masenf April 18, 2024 22:50
@picklelo picklelo merged commit a23faa2 into main Apr 20, 2024
46 checks passed
@masenf masenf deleted the add-color-example-readme branch April 24, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants