Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add toast component #3186
add toast component #3186
Changes from 12 commits
051ba15
64aee8f
d7ac3c6
a88f2c6
b63783f
3be9d4e
1ac44db
793ad52
419e570
0bfa6c8
635e603
a577287
3fe02c1
cef348c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i pass a lucide icon here, it gives a frontend error and crashes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i set this to
True
, the toasts still don't have a close buttonThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i set defaults here, they do not seem to be respected.
I tried setting it like
And the toasts still use the default 4000ms duration and do not have close buttons, unless i pass no options at all.
For example, i'm trying to toast like this
It seems that any options passed myself overwrite all of the toaster options with the original defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so i updated ToastProps to make all of the fields optional, which seemed to help; but now i'm finding that some of the fields in
ToastProps
don't take effect when passed to thetoast_options
prop.(maybe others, didn't try them all)