Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly replace ComputedVars #3254

Merged
merged 6 commits into from
May 15, 2024

Conversation

benedikt-bartscher
Copy link
Contributor

@benedikt-bartscher benedikt-bartscher commented May 8, 2024

Addresses issues with cached_vars reported in #3253

Closes #3253

@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review May 8, 2024 20:50
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks @benedikt-bartscher for jumping in on these fixes so quickly

@benedikt-bartscher
Copy link
Contributor Author

You are welcome. I'll add more tests for cached vars and background tasks in another PR

@masenf masenf merged commit 48c5046 into reflex-dev:main May 15, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rx.cached_var and rx.background don't work in mixins
2 participants