Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-2878] Map fontFamily to fontFamily and --default-font-family #3380

Merged
merged 1 commit into from
May 23, 2024

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented May 23, 2024

When setting the font_family prop for a component, also set the radix token --default-font-family so that child radix components will inherit the font.

When setting the font_family prop for a component, also set the radix token
`--default-font-family` so that child radix components will inherit the font.
Copy link

linear bot commented May 23, 2024

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@masenf masenf merged commit 653f00b into main May 23, 2024
47 checks passed
@masenf masenf deleted the masenf/global-font-family branch May 23, 2024 22:54
@onexay
Copy link

onexay commented May 31, 2024

Thanks!

benedikt-bartscher pushed a commit to benedikt-bartscher/reflex that referenced this pull request Jun 3, 2024
…flex-dev#3380)

When setting the font_family prop for a component, also set the radix token
`--default-font-family` so that child radix components will inherit the font.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants