fix var dependency dicts

[benedikt-bartscher]

Closes #3595

[benedikt-bartscher]

I missed the failing redis integration tests, going back to draft

[benedikt-bartscher]

Tests are fixed ✔️
However, I am thinking about delaying the initialization of the var dependency dicts to compile, to ensure they are only executed once. Currently, all dependencies are recalculated if you add a dynamic var (State.add_var) or a page with a dynamic route. They are reloaded in integration tests as well (reload_state_module). Moving this to compile should simplify the code and make it faster. WDYT @picklelo @masenf ?

Edit: I just tested it, works fine. All integration tests pass. But we need to call _init_var_dependency_dicts in some (19) unit tests which are not compiling the app and test var deps.

diff --git a/reflex/app.py b/reflex/app.py
index 5be0ef04..6e9c044b 100644
--- a/reflex/app.py
+++ b/reflex/app.py
@@ -799,6 +799,13 @@ class App(MiddlewareMixin, LifespanMixin, Base):
         for render, kwargs in DECORATED_PAGES[get_config().app_name]:
             self.add_page(render, **kwargs)
 
+    def _init_var_dependency_dicts(self):
+        """Recursively initialize the var dependency dictionaries for all state subclasses of the app."""
+        if not self.state:
+            return
+
+        self.state._init_var_dependency_dicts()
+
     def _validate_var_dependencies(
         self, state: Optional[Type[BaseState]] = None
     ) -> None:
@@ -853,6 +860,7 @@ class App(MiddlewareMixin, LifespanMixin, Base):
         if not self._should_compile():
             return
 
+        self._init_var_dependency_dicts()
         self._validate_var_dependencies()
         self._setup_overlay_component()
         self._setup_error_boundary()
diff --git a/reflex/state.py b/reflex/state.py
index 8fcaa7e1..a98acc2c 100644
--- a/reflex/state.py
+++ b/reflex/state.py
@@ -592,7 +592,6 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
         # Initialize per-class var dependency tracking.
         cls._computed_var_dependencies = defaultdict(set)
         cls._substate_var_dependencies = defaultdict(set)
-        cls._init_var_dependency_dicts()
 
     @staticmethod
     def _copy_fn(fn: Callable) -> Callable:
@@ -653,7 +652,7 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
 
     @classmethod
     def _init_var_dependency_dicts(cls):
-        """Initialize the var dependency tracking dicts.
+        """Recursively initialize the var dependency tracking dicts for the state and all substates.
 
         Allows the state to know which vars each ComputedVar depends on and
         whether a ComputedVar depends on a var in its parent state.
@@ -701,6 +700,9 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
                     parent_state.get_parent_state(),
                 )
 
+        for substate in cls.get_substates():
+            substate._init_var_dependency_dicts()
+
     @classmethod
     def _check_overridden_methods(cls):
         """Check for shadow methods and raise error if any.
@@ -918,9 +920,6 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
         for substate_class in cls.class_subclasses:
             substate_class.vars.setdefault(name, var)
 
-        # Reinitialize dependency tracking dicts.
-        cls._init_var_dependency_dicts()
-
     @classmethod
     def _set_var(cls, prop: ImmutableVar):
         """Set the var as a class member.
@@ -1037,9 +1036,6 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
             cls.vars[param] = cls.computed_vars[param] = func._var_set_state(cls)  # type: ignore
             setattr(cls, param, func)
 
-        # Reinitialize dependency tracking dicts.
-        cls._init_var_dependency_dicts()
-
     def __getattribute__(self, name: str) -> Any:
         """Get the state var.
 
@@ -3365,5 +3361,4 @@ def reload_state_module(
             state._always_dirty_substates.discard(subclass.get_name())
     state._computed_var_dependencies = defaultdict(set)
     state._substate_var_dependencies = defaultdict(set)
-    state._init_var_dependency_dicts()
     state.get_class_substate.cache_clear()

As a bonus point, this will only calculate var dependencies for state subclasses of the app's main state, instead of all state classes which are imported.

[benedikt-bartscher]

@masenf I just noticed you already tried something similar here: #2822

[benedikt-bartscher]

However, I am thinking about delaying the initialization of the var dependency dicts to compile, to ensure they are only executed once.

Implemented in f3a98f3

[benedikt-bartscher]

I think we are safe to adjust the cache to be True by default after merging this one

btw: failing example-counter tests seem not related to this PR

[benedikt-bartscher]

Is there anything else I can do to get this fix in?

[masenf]

@benedikt-bartscher reviewing today. i think we can bring it in, thanks for the nudge

[picklelo]

nice catch - the example is working for me