Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include emotion inside of dynamic components #4052

Merged
merged 10 commits into from
Oct 3, 2024
Merged

Include emotion inside of dynamic components #4052

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
aabb1ed
bundle chakra in window for CSR
adhami3310 Oct 2, 2024
4a96c76
remove repeated chakra ui reference
adhami3310 Oct 2, 2024
29f864f
use dynamically generated libraries
adhami3310 Oct 3, 2024
062dd55
merging
adhami3310 Oct 3, 2024
e0580eb
remove js from it
adhami3310 Oct 3, 2024
c85b477
include emotion react for dynamic components
adhami3310 Oct 3, 2024
89358f2
merging
adhami3310 Oct 3, 2024
88a1571
make code more readable
adhami3310 Oct 3, 2024
c1895f9
jsx yea
adhami3310 Oct 3, 2024
172bf94
what
adhami3310 Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions reflex/components/dynamic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ def get_cdn_url(lib: str) -> str:
return f"https://cdn.jsdelivr.net/npm/{lib}" + "/+esm"


bundled_libraries = {"react", "@radix-ui/themes"}
bundled_libraries = {
"react",
"@radix-ui/themes",
"@emotion/react",
}


def bundle_library(component: "Component"):
Expand Down Expand Up @@ -127,7 +131,14 @@ def make_component(component: Component) -> str:

module_code_lines.insert(0, "const React = window.__reflex.react;")

return "//__reflex_evaluate\n" + "\n".join(module_code_lines)
return "\n".join(
[
"//__reflex_evaluate",
"/** @jsx jsx */",
"const { jsx } = window.__reflex['@emotion/react']",
*module_code_lines,
]
)

@transform
def evaluate_component(js_string: Var[str]) -> Var[Component]:
Expand Down
Loading