test_dynamic_routes: log on_loads and poll for 60 seconds on order #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert on `list(...order)` so the error message prints actual value instead of MutableProxy's repr. Not sure if this fixes it...
picklelo
approved these changes
Oct 8, 2024
|
i've ran it 3 times now with no flakes, i'll keep re-running and see if any shake out. i never did get a repro on my local (my machine is too fast) |
Kastier1
pushed a commit
that referenced
this pull request
Oct 23, 2024
…4089) Assert on `list(...order)` so the error message prints actual value instead of MutableProxy's repr. Not sure if this fixes it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert on
list(...order)so the error message prints actual value instead of MutableProxy's repr.Not sure if this fixes it...