Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make var system expandable #4175

Merged
merged 20 commits into from
Oct 22, 2024
Merged

make var system expandable #4175

merged 20 commits into from
Oct 22, 2024

Conversation

adhami3310
Copy link
Member

No description provided.

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is cool. cleans up a lot of more complex code that i think will improve maintainability

reflex/vars/base.py Outdated Show resolved Hide resolved
reflex/vars/base.py Outdated Show resolved Hide resolved
@adhami3310 adhami3310 linked an issue Oct 15, 2024 that may be closed by this pull request
@masenf masenf merged commit 54ad9f0 into main Oct 22, 2024
31 checks passed
Kastier1 pushed a commit that referenced this pull request Oct 23, 2024
* make var system expandable

* use old syntax

* remove newer features

* that's a weird error

* remove unnecessary error message

* remove hacky getattr as it's no longer necessary

* improve color handling

* get it right pyright

* dang it darglint

* fix prototype to string

* don't try twice

* adjust test case

* add test for var alpha

* change place of type ignore

* fix json

* add name to custom var operation

* don't delete that you silly

* change logic

* remove extra word
@masenf masenf deleted the make-var-system-expandable branch December 12, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Want to change the color depending on the conditions.
2 participants