[ENG-3989] Ensure non-serialized states are present in StateManagerDisk #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a non-root state was serialized, but its substates were not, then these would not be populated when reloading the pickled state, because only substates from the root were being populated with fresh versions. Now, capture the substates from all fresh states and apply them to the deserialized state for each substate to ensure that the entire state tree has all substates instantiated after deserializing, even substates that were never serialized originally.
Lendemor
approved these changes
Oct 23, 2024
masenf
added a commit
that referenced
this pull request
Oct 23, 2024
…sk (#4230) If a non-root state was serialized, but its substates were not, then these would not be populated when reloading the pickled state, because only substates from the root were being populated with fresh versions. Now, capture the substates from all fresh states and apply them to the deserialized state for each substate to ensure that the entire state tree has all substates instantiated after deserializing, even substates that were never serialized originally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a non-root state was serialized, but its substates were not, then these would not be populated when reloading the pickled state, because only substates from the root were being populated with fresh versions.
Now, capture the substates from all fresh states and apply them to the deserialized state for each substate to ensure that the entire state tree has all substates instantiated after deserializing, even substates that were never serialized originally.
Fixes #4227