fix(router): fix replaceState compatibility with jsdom
#10001
Conversation
Workaround upstream jsdom bug: jsdom/jsdom#3504 The third argument to replaceState is optional, but provide it anyway for improved compatibility with all environments. The call to replaceState was introduced in bb7590a.
🦋 Changeset detectedLatest commit: 9b63280 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MichaelDeBoey
changed the title
replaceState compatibility with jsdom
|
I was able to find a local workaround as well. So if you prefer to close, it is no problem for me and I'll continue with the workaround I have. |
|
Thanks @jdufresne! Since this changes code, would you mind rebasing it and re-pointing it at the |
|
Thank you for the review, but I'm going to close this PR in favor of persuing a fix upstream. React Router is using the History API as documented, so it shouldn't need to change. My local workaround is sufficient until JSDOM is fixed. Thanks again. |
|
For people interested in the PR: jsdom/jsdom#3505 |
Workaround upstream jsdom bug:
jsdom/jsdom#3504
The third argument to replaceState is optional, but provide it anyway for improved compatibility with all environments.
The call to replaceState was introduced in
bb7590a.