-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix useLocation to receive 0 instead of null when state is set to 0 #11450
Conversation
|
Hi @jungwoo3490, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@@ -86,7 +86,7 @@ export function StaticRouter({ | |||
pathname: locationProp.pathname || "/", | |||
search: locationProp.search || "", | |||
hash: locationProp.hash || "", | |||
state: locationProp.state || null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jungwoo3490 since you discovered this bug (🥳 ), I think this is not a full fix. You still can't set state to ""
, false
, undefined
or NaN
. Maybe the change should be
state: locationProp.state
, which defaults to undefined
, or with some check for other falsy values. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hjonasson
You're right. So I changed it to nullish coalescing operator and opened new PR.
Can you check my new PR?? #11495
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever 👍
Fixes #11448
I fixed location's state property value like this.
Now, useLocation receive 0 instead of null when state is set to 0.