Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useLocation to receive 0 instead of null when state is set to 0 #11450

Closed
wants to merge 2 commits into from

Conversation

jungwoo3490
Copy link
Contributor

Fixes #11448

I fixed location's state property value like this.

let location: Location = {
  pathname: locationProp.pathname || "/",
  search: locationProp.search || "",
  hash: locationProp.hash || "",
  state: locationProp.state ? locationProp.state === 0 ? 0 : locationProp.state : null, // fixed
  key: locationProp.key || "default",
};

Now, useLocation receive 0 instead of null when state is set to 0.

Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: d77d27a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 15, 2024

Hi @jungwoo3490,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 15, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@@ -86,7 +86,7 @@ export function StaticRouter({
pathname: locationProp.pathname || "/",
search: locationProp.search || "",
hash: locationProp.hash || "",
state: locationProp.state || null,
Copy link

@hjonasson hjonasson May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jungwoo3490 since you discovered this bug (🥳 ), I think this is not a full fix. You still can't set state to "", false, undefined or NaN. Maybe the change should be

state: locationProp.state, which defaults to undefined, or with some check for other falsy values. What do you think?

Copy link
Contributor Author

@jungwoo3490 jungwoo3490 May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjonasson
You're right. So I changed it to nullish coalescing operator and opened new PR.
Can you check my new PR?? #11495

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants