Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetcher.submit types #11631

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Fix fetcher.submit types #11631

merged 3 commits into from
Jun 13, 2024

Conversation

brophdawg11
Copy link
Contributor

Fixes type issue from #11627

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d207bb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Jun 7, 2024 that may be closed by this pull request
[Bug]: useFetcher options navigate true does not work #11627
Closed
brophdawg11
brophdawg11 commented Jun 13, 2024
View reviewed changes
packages/react-router-dom/dom.ts Outdated
@@ -150,7 +150,7 @@ function isFormDataSubmitterSupported() {
return _formDataSupportsSubmitter;
}

export interface SubmitOptions {
export interface FetcherSubmitOptions {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of directly definig these here, have a base private SharedSubmitOptions that can be extended. That way it's not easy to add something fetcher-only and accidentally leak it to non-fetcher cases. Do this for FetcherFormProps as well

@brophdawg11 brophdawg11 merged commit be8a259 into dev Jun 13, 2024
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/fix-types branch June 13, 2024 21:28
@brophdawg11 brophdawg11 mentioned this pull request Jun 13, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.24.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@brophdawg11 brophdawg11 mentioned this pull request Jun 18, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.24.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: useFetcher options navigate true does not work
1 participant
@brophdawg11